[asterisk-dev] [asterisk-commits] tilghman: trunk r130126 - in /trunk: ./ channels/chan_agent.c

[Caio Begotti]

I'm not currently subscribed to the -commits list, so I just manually  
pasted below the relevant parts of it from the archive:

Author: tilghman
Date: Fri Jul 11 12:29:24 2008
New Revision: 130126

URL: http://svn.digium.com/view/asterisk?view=rev&rev=130126
Log:
Merged revisions 130102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r130102 | tilghman | 2008-07-11 11:50:42 -0500 (Fri, 11 Jul 2008) | 9  
lines

Pass the devicestate from an underlying channel up through the Agent  
channel.
This should make the Agent always report the correct device state,  
even when
the underlying channel is used for other purposes.
(closes issue #12773)
  Reported by: davidw
  Patches:
        20080710__bug12773.diff.txt uploaded by Corydon76 (license 14)
  Tested by: davidw

........

Modified:
     trunk/   (props changed)
     trunk/channels/chan_agent.c

Propchange: trunk/
------------------------------------------------------------------------ 
------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/channels/chan_agent.c
URL: http://svn.digium.com/view/asterisk/trunk/channels/chan_agent.c? 
view=diff&rev=130126&r1=130125&r2=130126
======================================================================== 
======
--- trunk/channels/chan_agent.c (original)
+++ trunk/channels/chan_agent.c Fri Jul 11 12:29:24 2008

@@ -2433,6 +2487,8 @@
+	agent_devicestate_sub = ast_event_subscribe(AST_EVENT_DEVICE_STATE,  
agent_devicestate_cb, NULL);

@@ -2450,6 +2506,8 @@
+	/* Delete devicestate subscription */
+	agent_devicestate_sub = ast_event_unsubscribe(agent_devicestate_sub);

I don't know why but this merge to trunk broke chan_agent under OSX.

The module chan_agent apparently loads ok sometimes but if you try to  
unload and load it back Asterisk crashes or either stays consuming  
all CPU power. I've tried to get a bt full to post but for some weird  
reason it seems to be empty here, I am not able to check it at the  
moment to proper reopen #12773. Also, I didn't try it under my Linux  
installation but the 1.4 branch works fine on the same OSX machine  
though.

Does anyone else confirm it's not working under OSX right now?

--
Caio Begotti