[asterisk-dev] Locking, coding guidelines addition

[Russell Bryant]

----- "Raj Jain" <rj2807 at gmail.com> wrote:

> Thanks for documenting these coding guidelines. The C++ inheritance
> analogy is a good one for explaining this. If ast_channel is in
> principle "abstract", then that further supports the design thought
> that it shouldn't have a lock of its own.

Yes, I absolutely agree.  It's the way I would do it given the time to make such an architectural improvement, or if I were re-designing things.
 
> I would consider that (using sip_pvt for registrations and
> subscriptions) as a design flaw. sip_pvt isn't really a "derivation"
> of ast_channel for those specific usages.

Yes.  :)

-- 
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.