[asterisk-dev] rizzo: trunk r95069 - in /trunk/apps: app_ices.c app_queue.c app_voicemail.c

[Mark Michelson]

Tony Mountifield wrote:
> In article <20071231164243.A78443 at xorpc.icir.org>,
> Luigi Rizzo <rizzo at icir.org> wrote:
>> On Mon, Dec 31, 2007 at 12:55:41PM -0600, Kevin P. Fleming wrote:
>>> Tony Mountifield wrote:
>>>
>>>> In summary, a cast before a NULL function argument can only be omitted
>>>> when that argument has an explicit prototype.
>>> Jeepers... I knew all of this, and I saw rizzo's commit and thought
>>> 'hmm, i wonder if that is OK' but didn't connect it. Thanks for
>>> thoroughly documenting this!
>> many thanks for the detailed explaination from me as well.
>> I had not hit this particular issue before, so it is always good
>> to learn something new.
> 
> I haven't seen any commits to reinstate the required casts that had been
> removed. Just wanted to make sure it doesn't get forgotten...
> 
> Cheers
> Tony

Actually, this has been fixed. Michiel Van Baak submitted a patch on the 
bugtracker reinstating the casting in all places where a sentinel NULL was 
required (execl and execlp calls). The bug number was 11669 and the SVN revision 
where it was fixed was 96147. If there are any other places where this needs to 
be done, don't hesitate to submit a patch.

Mark Michelson