[asterisk-dev] Coding guidelines change (proposed)

[Maxim Sobolev]

Tilghman Lesher wrote:
> I'd like to propose a change to the coding guidelines, and I'm airing it here
> for specific feedback before we make this change.  Currently, our standard
> is that if you have a single statement following an if/for/while construct,
> then we do not require parentheses around the single statement.  While this
> is legal C, it has caused a number of issues in the past, where another
> statement was added at that indentation level, but without adding the
> necessary braces.
> 
> I'd like to change the coding guidelines that the braces are no longer
> optional; that they are mandatory, and if this change is approved, a janitor
> project will be posted shortly to convert legacy code to the new standard.
> 
> Are there any comments or objections before we implement this change?

While I like the idea, however disagree with "a janitor project to 
convert all code" extension strongly. It will introduce significant 
superfluous changes to the code, unnecessarily complicating life of 
people who maintain custom patches for asterisk.

Regards,
-- 
Maksym Sobolyev
Sippy Software, Inc.
Internet Telephony (VoIP) Experts
T/F: +1-646-651-1110
Web: http://www.sippysoft.com