[asterisk-dev] Coding guidelines change (proposed)

Steve Edwards asterisk.org at sedwards.com
Tue Feb 26 12:59:18 CST 2008


On Tue, 26 Feb 2008, Tilghman Lesher wrote:

> I'd like to propose a change to the coding guidelines, and I'm airing it here
> for specific feedback before we make this change.  Currently, our standard
> is that if you have a single statement following an if/for/while construct,
> then we do not require parentheses around the single statement.  While this
> is legal C, it has caused a number of issues in the past, where another
> statement was added at that indentation level, but without adding the
> necessary braces.
>
> I'd like to change the coding guidelines that the braces are no longer
> optional; that they are mandatory, and if this change is approved, a janitor
> project will be posted shortly to convert legacy code to the new standard.
>
> Are there any comments or objections before we implement this change?

+1 -- should have been done from the start :)

If the coding guidelines are up for review, how about allowing // for 
commenting?

Thanks in advance,
------------------------------------------------------------------------
Steve Edwards      sedwards at sedwards.com      Voice: +1-760-468-3867 PST
Newline                                             Fax: +1-760-731-3000



More information about the asterisk-dev mailing list