[asterisk-dev] [Code Review] Make 'core show sysinfo' work on systems that dont have sysinfo but do have sysctl (Like OpenBSD)

[Michiel van Baak]

> On 2008-12-14 06:21:20, Russell Bryant wrote:
> > trunk/main/asterisk.c, line 518
> > <http://reviewboard.digium.com/r/91/diff/1/?file=1887#file1887line518>
> >
> >     use ast_calloc

done


> On 2008-12-14 06:21:20, Russell Bryant wrote:
> > trunk/main/asterisk.c, lines 560-562
> > <http://reviewboard.digium.com/r/91/diff/1/?file=1887#file1887line560>
> >
> >     Add spaces around '/'

done


> On 2008-12-14 06:21:20, Russell Bryant wrote:
> > trunk/main/asterisk.c, lines 571-572
> > <http://reviewboard.digium.com/r/91/diff/1/?file=1887#file1887line571>
> >
> >     Did you really need (void) here?

nope, removed it.


> On 2008-12-14 06:21:20, Russell Bryant wrote:
> > trunk/main/asterisk.c, line 604
> > <http://reviewboard.digium.com/r/91/diff/1/?file=1887#file1887line604>
> >
> >     add spaces around '-'

done


- Michiel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/91/#review219
-----------------------------------------------------------


On 2008-12-14 10:18:54, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/91/
> -----------------------------------------------------------
> 
> (Updated 2008-12-14 10:18:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> OpenBSD (and some others) dont have the sysinfo functionality found in Linux.
> The same information can be found using sysctl on those systems.
> 
> 
> This addresses bug 13433.
>     http://bugs.digium.com/view.php?id=13433
> 
> 
> Diffs
> -----
> 
>   trunk/configure 164138 
>   trunk/configure.ac 164138 
>   trunk/include/asterisk/autoconfig.h.in 164138 
>   trunk/main/asterisk.c 164138 
> 
> Diff: http://reviewboard.digium.com/r/91/diff
> 
> 
> Testing
> -------
> 
> compiles and works on OpenBSD 4.4 amd64
> 
> 
> Thanks,
> 
> Michiel
> 
>