[asterisk-dev] [Code Review] Make 'core show sysinfo' work on systems that dont have sysinfo but do have sysctl (Like OpenBSD)

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/91/#review219
-----------------------------------------------------------



trunk/main/asterisk.c
<http://reviewboard.digium.com/r/91/#comment426>

    use ast_calloc



trunk/main/asterisk.c
<http://reviewboard.digium.com/r/91/#comment427>

    Add spaces around '/'



trunk/main/asterisk.c
<http://reviewboard.digium.com/r/91/#comment428>

    Did you really need (void) here?



trunk/main/asterisk.c
<http://reviewboard.digium.com/r/91/#comment429>

    add spaces around '-'


- Russell


On 2008-12-13 07:33:52, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/91/
> -----------------------------------------------------------
> 
> (Updated 2008-12-13 07:33:52)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> OpenBSD (and some others) dont have the sysinfo functionality found in Linux.
> The same information can be found using sysctl on those systems.
> 
> 
> This addresses bug 13433.
>     http://bugs.digium.com/view.php?id=13433
> 
> 
> Diffs
> -----
> 
>   trunk/configure 164027 
>   trunk/configure.ac 164027 
>   trunk/include/asterisk/autoconfig.h.in 164027 
>   trunk/main/asterisk.c 164027 
> 
> Diff: http://reviewboard.digium.com/r/91/diff
> 
> 
> Testing
> -------
> 
> compiles and works on OpenBSD 4.4 amd64
> 
> 
> Thanks,
> 
> Michiel
> 
>