[asterisk-dev] [Code Review] Patch pbx_dundi.c to periodically clean it's database cache
Matthew Nicholson
mnicholson at digium.com
Mon Dec 8 16:18:31 CST 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/63/
-----------------------------------------------------------
(Updated 2008-12-08 16:18:31.505532)
Review request for Asterisk Developers.
Changes
-------
Switched to using pthread_cancel to kill the cache cleaning thread rather than pthread_kill().
Summary
-------
This is a modified version of the patch from bug 13819 (http://bugs.digium.com/view.php?id=13819). It spawns a thread to remove expired entries from the dundi cache (in astdb) every 60 seconds. This patch is necessary because asterisk normally cleans these entries when they are looked up, but entries that are not retrieved often (or retrieved only once ever) will stay in the database.
This addresses bug 13819.
http://bugs.digium.com/view.php?id=13819
Diffs (updated)
-----
asterisk/branches/1.6.0/pbx/pbx_dundi.c 158369
Diff: http://reviewboard.digium.com/r/63/diff
Testing
-------
I tested this by creating some expired entries in the database using 'database put dundi/cache test 0|0' and observed asterisk clean them up.
Thanks,
Matthew
More information about the asterisk-dev
mailing list