[asterisk-dev] [svn-commits] qwell: branch 1.4 r160764 - /branches/1.4/channels/chan_agent.c

Jason Parker jparker at digium.com
Wed Dec 3 16:03:53 CST 2008


Russell Bryant wrote:
> Julian Lyndon-Smith wrote:
>> Not being a C programmer, but a lazy one, why doesn't the ast_verbose 
>> function call check the current level and only output the message if the 
>> current level is eq to or greater than the _prefix ?
>>
>> This would remove the need to have
>>
>> if (option_verbose > 2)
>> 		ast_verbose(VERBOSE_PREFIX_3 ...
>>
>> and only have
>>
>> ast_verbose(VERBOSE_PREFIX_3 ...
>>
>> I know speed must be a consideration, but isn't the difference in order 
>> of microseconds ?
>>
>> /me dons the heavy-duty flamesuit and awaits the derision of the -dev 
>> list ...
> 
> That's why we have ast_verb() in trunk, which is just such a wrapper.  :)
> 

And why this commit was blocked in trunk, since that message is using the
wrapper there.



More information about the asterisk-dev mailing list