[asterisk-dev] [svn-commits] qwell: branch 1.4 r160764 - /branches/1.4/channels/chan_agent.c

Russell Bryant russell at digium.com
Wed Dec 3 15:45:46 CST 2008


Julian Lyndon-Smith wrote:
> Not being a C programmer, but a lazy one, why doesn't the ast_verbose 
> function call check the current level and only output the message if the 
> current level is eq to or greater than the _prefix ?
> 
> This would remove the need to have
> 
> if (option_verbose > 2)
> 		ast_verbose(VERBOSE_PREFIX_3 ...
> 
> and only have
> 
> ast_verbose(VERBOSE_PREFIX_3 ...
> 
> I know speed must be a consideration, but isn't the difference in order 
> of microseconds ?
> 
> /me dons the heavy-duty flamesuit and awaits the derision of the -dev 
> list ...

That's why we have ast_verb() in trunk, which is just such a wrapper.  :)

-- 
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.



More information about the asterisk-dev mailing list