[asterisk-dev] builtin values and CLI changes in res_features

[Michiel van Baak]

On 17:16, Tue 04 Sep 07, Eric ManxPower Wieling wrote:
> Michiel van Baak wrote:
> > On 16:05, Tue 04 Sep 07, Caio Begotti wrote:
> >> Hi, I'm looking to know what do you guys think about the changes
> >> posted at: http://bugs.digium.com/10524
> >>
> >> I've talked to Junk-Y and he told me the CLI changes are nice but
> >> he's not so sure about removing default builtins. My argument is in
> >> the link above, but it's that having default builtins for features
> >> like transfer and parking is wrong when you must set a blank value to
> >> set it off.
> >>
> >> I just don't know wheter it's "wrong and silly" or "wrong but
> >> acceptable for most people". That's why I'm asking for input :-)
> >>
> >> There are samples attached in 10524 showing what changes as well. Do
> >> you think this can be commited in trunk or removing default builtins
> >> such like that is risky?
> > 
> > Removing defaults is something you cant do that easily.
> > people depend on them.
> > 
> > What's wrong with the defaults if you state in the
> > upgrade.txt that you can now alter all this stuff and also
> > alter the sample config to reflect the new possibilities ?
> 
> Why not take the hardcoded defaults out of the source code and put them 
> in feature.conf where they should have been in the first place?

That would be ok if you ask me.
That way people who built their systems using the hardcoded
stuff would still be in business.
Make sure to state this in the UPGRADE.txt

-- 

Michiel van Baak
michiel at vanbaak.eu
http://michiel.vanbaak.eu
GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x71C946BD

"Why is it drug addicts and computer afficionados are both called users?"