[asterisk-dev] [asterisk-commits] mmichelson: branch 1.4 r89205 - /branches/1.4/apps/app_mixmonitor.c

[BJ Weschke]

Kevin P. Fleming wrote:
> SVN commits to the Asterisk project wrote:
>
>   
>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=89205
>> Log:
>> Some sanity checking for MixMonitor. If only 1 argument is given, then the args.options
>> and args.post_process strings are uninitialized and could contain garbage. This change
>> handles this situation properly by only using arguments that we have parsed.
>>     
>
> I don't believe this is correct; one of the first things that
> ast_app_separate_args() does is to memset() the entire args array to
> zeros; this was done so that applications could just check for any
> specific argument being non-NULL without having to check the argument
> count as well.
>
>   

 Kevin -

 That may be the intent, but Mark isn't the only one that's seen this 
behavior.

 If I run ast_app_separate_args() on arg1|arg2|arg3|arg4 represented as 
"foo|||bar" I'm seeing arg2 and arg3 come in null.


-- 
--
Bird's The Word Technologies, Inc.
http://www.btwtech.com/