[asterisk-dev] missing seqno setting in rtp.c::ast_rtp_read()

Russell Bryant russell at digium.com
Tue Jul 24 15:53:45 CDT 2007


Luigi Rizzo wrote:
>                rtp->f.seqno = seqno;
>  
> in ast_rtp_read() is done only for audio frames.
> We think it is useful if not necessary for video as well,
> and given that there is room in the struct header, why
> don't keep the info unconditionally also for other frame types ?
> 
> I'd be tempted to move the assignment before the test for
> audio/video/other frames.

It sounds like a valid bug to me.  Media types other than audio really just 
haven't been nearly as stressed and used as the code for handling audio has been.

-- 
Russell Bryant
Software Engineer
Digium, Inc.



More information about the asterisk-dev mailing list