[asterisk-dev] Re: [asterisk-commits] dhubbard: branch 1.4 r60325 - /branches/1.4/formats/format_wav.c

[Kevin P. Fleming]

asterisk-commits at lists.digium.com wrote:

> Modified: branches/1.4/formats/format_wav.c
> URL: http://svn.digium.com/view/asterisk/branches/1.4/formats/format_wav.c?view=diff&rev=60325&r1=60324&r2=60325
> ==============================================================================
> --- branches/1.4/formats/format_wav.c (original)
> +++ branches/1.4/formats/format_wav.c Thu Apr  5 17:58:01 2007
> @@ -61,7 +61,8 @@
>  
>  #define BLOCKSIZE 160
>  
> -#define GAIN 2		/* 2^GAIN is the multiple to increase the volume by */
> +#define GAIN 0		/* 2^GAIN is the multiple to increase the volume by.  The original value of GAIN was 2, or 4x (12 dB),
> +			 * but there were many reports of the clipping of loud signal peaks (issue 5823 for example). */

Since GAIN is now zero, instead of just changing the value it should be
removed, along with any code that used the value, since it will no
longer have any effect.