[asterisk-dev] Re: [asterisk-users] 488 Not acceptable here sent by Asterisk - SIPdebug follows

[Dinesh Nair]

On 09/20/06 15:06 Dinesh Nair said the following:
> 
> 
> On 09/19/06 16:59 Steve Langstaff said the following:
> 
>> I wonder whether you are experiencing the following bug (since the SIP
>> INVITE has a multipart SDP body):
>> http://bugs.digium.com/view.php?id=7124&nbn=4
> 
> 
> thanks for the link,
> 
> however, on 18th may 2006, kpfleming's note says, "This should be fixed 
> in both 1.2 branch and trunk," and i'm using 1.2.12.1 which was just 
> released this week. looking thru the current chan_sip.c code, it does 
> seem like kevin's modified patch has been committed into the branch i'm 
> using, so this isnt the problem.

[am cc'ing reply into -dev because a bug report was opened on this at 
http://bugs.digium.com/view.php?id=8010 with a patch provided]

i've managed to track this down to a loop which terminated prematurely in 
find_sdp() in chan_sip.c. this bug would have prevented proper handling of 
multipart/mixed content types due to the loop which searches for the end of 
the block ending prematurely and setting req->sdp_start > req->sdp_end.

i've provided patches for trunk and 1.2.x in the bug entry, as i think this 
should also be committed to 1.2.x.

-- 
Regards,                           /\_/\   "All dogs go to heaven."
dinesh at alphaque.com                (0 0)   http://www.openmalaysiablog.com/
+==========================----oOO--(_)--OOo----==========================+
| for a in past present future; do                                        |
|   for b in clients employers associates relatives neighbours pets; do   |
|   echo "The opinions here in no way reflect the opinions of my $a $b."  |
| done; done                                                              |
+=========================================================================+