[asterisk-dev] Possible bug in chan_zap.c

[Jared Smith]

On Tue, 2006-02-07 at 17:19 +0200, Slav Klenov wrote:
> In function
> static struct zt_pvt *mkintf(int channel, int signalling, int radio, 
> struct zt_pri *pri, int reloading)
> in chan_zap.c line 7035 (svn trunk from today) we have:
> 
>     if (p.sigtype != (signalling & 0x3ffff)) {
>         ast_log(LOG_ERROR, "Signalling requested on channel %d is %s but 
> line is in %s signalling\n", channel, sig2str(signalling), 
> sig2str(p.sigtype));
>         destroy_zt_pvt(&tmp);
>         return tmp;
>     }
> 
> Shouldn't we return NULL in this case?

Thanks for your help!

Please open a bug ticket at http://bugs.digium.com/ so that this can be
tracked and corrected if it needs to be.  This way, it won't get lost.

-Jared