[asterisk-dev] Possible bug in chan_zap.c

[Slav Klenov]

Hello list,

In function
static struct zt_pvt *mkintf(int channel, int signalling, int radio, 
struct zt_pri *pri, int reloading)
in chan_zap.c line 7035 (svn trunk from today) we have:

    if (p.sigtype != (signalling & 0x3ffff)) {
        ast_log(LOG_ERROR, "Signalling requested on channel %d is %s but 
line is in %s signalling\n", channel, sig2str(signalling), 
sig2str(p.sigtype));
        destroy_zt_pvt(&tmp);
        return tmp;
    }

Shouldn't we return NULL in this case?

Slav