[asterisk-dev] Re: [svn-commits] file: branch 1.4 r319- /branches/1.4/asterisk-ooh323c/src/chan_h323.c

[Dan Austin]

Russell wrote:
>> --- branches/1.4/asterisk-ooh323c/src/chan_h323.c (original)
>> +++ branches/1.4/asterisk-ooh323c/src/chan_h323.c Thu Dec 14 16:19:53
2006
>> @@ -247,15 +247,13 @@
>>  
>>     /* Don't hold a h323 pvt lock while we allocate a channel */
>>     ast_mutex_unlock(&i->lock);
>> -   ch = ast_channel_alloc(1);
>> +   ch = ast_channel_alloc(1, state, i->callerid_num,
i->callerid_name, "OOH323/%s-%04x", host, rand() & 0xffff);
>>     ast_mutex_lock(&i->lock);
>>  
>>     if(ch)
>>     {
>>        ast_mutex_lock(&ch->lock);
>>        ch->tech = &ooh323_tech;
>> -      ast_string_field_build(ch, name, "OOH323/%s-%04x", 
>> -                                                     host, rand() &
0xffff);
>>  
>>        ch->nativeformats = i->capability;

> Just as you removed the code that manually set the channel name, the
code
> that sets the channel state and callerid information needs to be
removed 
> as well.

My appologies.  I spotted chan_ooh323 not building and had to dig
through
five weeks of updates to find the change to ast_channel_alloc and why.

I did not notice the changes to state and channel name, and file was
covering
my half-assed patch....

I can get another cmall patch up on mantis if that would be the best
thing
to do.

Dan