[asterisk-dev] gratuitous change in rev.48416 ?

Russell Bryant russell at digium.com
Tue Dec 12 17:59:21 MST 2006


----- Russell Bryant <russell at digium.com> wrote:
> ----- Kevin P. Fleming <kpfleming at digium.com> wrote:
> > Luigi Rizzo wrote:
> > > I'd suggest to revert this and, if necessary, make the
> > > change to codecs/codec_zap.c
> 
> If that's true, then I apologize.  I when I saw the compiler errors
> had something
> to do with "zap", I just assumed it was chan_zap, I guess.  Sorry ...

I meant "When I saw the ...".

> 
> > I'm not even sure why this is needed, when we can already test for
> > the proper things in the configure script.
> 
> Right, but as I stated in this commit message, checking for this type
> of thing
> is the right thing to do, but it doesn't help existing checkouts
> unless we
> force re-running the configure script after any code change.  So,
> something is
> better than nothing, and in this case, a proper message with the
> failure at
> build time is better than the standing compilation failure leaving the
> person
> to wonder what the problem is.

I meant "better than the standard compilation failure messages".  I can't
type today.

Anyway, I reverted this change from chan_zap.c.

-- 
Russell Bryant
Software Engineer
Digium, Inc.



More information about the asterisk-dev mailing list