[asterisk-dev] gratuitous change in rev.48416 ?

[Matt O'Gorman]

Its only used by codec_zap, if it is causing you a problem don't build codec_zap, menuselect does wonders.  I realize I probably should have updated checks for newer zaptel but it is trunk, things break. Sorry for the inconvenience.

Mog
----- Original Message -----
From: Luigi Rizzo <rizzo at icir.org>
To: Asterisk Developers Mailing List <asterisk-dev at lists.digium.com>
Sent: Tuesday, December 12, 2006 4:56:25 PM GMT-0600 US/Central
Subject: [asterisk-dev] gratuitous change in rev.48416 ?

i don't understand the change in  rev.48416 :

it seems that ZT_TCOP_RELEASE is not used here, and if
anything, it's codecs/codec_zap.c that fails to build,
not this one, so why make the compiler fail here and
not in the other module ?

I know that you are fond of the latest and greatest
versions of any software, but please realise that
newest zaptel drivers are not available on all platforms,
and making the code buildable on more platforms helps
a lot in discovering bugs.

I'd suggest to revert this and, if necessary, make the
change to codecs/codec_zap.c

	cheers
	luigi

--- trunk/channels/chan_zap.c	2006/12/10 03:14:27	48373
+++ trunk/channels/chan_zap.c	2006/12/12 22:27:22	48416
@@ -118,7 +118,7 @@
 };
 static struct ast_jb_conf global_jbconf;
 
-#if !defined(ZT_SIG_EM_E1) || (defined(HAVE_PRI) && !defined(ZT_SIG_HARDHDLC))
+#if !defined(ZT_TCOP_RELEASE) || (defined(HAVE_PRI) && !defined(ZT_SIG_HARDHDLC))
 #error "Your zaptel is too old.  Please update"
 #endif

now it turns out that 


_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev