[asterisk-dev] chan_skinny - SCOigo is now TROLLING

[Simon Lockhart]

On Thu Apr 06, 2006 at 09:58:16AM +0200, Sergio Chersovani wrote:
> Everybody knows that the CCM can't change the lamp on speddials button.
> 
> The chan_sccp does it with a trick, alot of work on the code and a good 
> idea.
> 
> So stop it and go learn something about the protocol.

As someone who has spent quite a bit of time analysing the SCCP protocol with
packet sniffers, and CCM Lite, I know a fair bit about how the protocol works.
You will find a whole bunch of my code in chan_skinny from when I was 
intending to expand its functionality quite considerably. I gave up when I
seemed to be operating solo.

If this functionality is available in CCM Lite now, which it appears it is, 
then it wouldn't be too hard to replicate the functionality in chan_skinny.
 
My concern right now is that, having worked with the chan_sccp code (you've got
patches in the code base from me to fix up endian problems), I will be accused
of stealing code or ideas from chan_sccp if I were to go back to developing 
for chan_skinny.

Once you've got an algorithm for providing certain functionality, it's quite
common to end up with similar code. Perhaps the code in chan_skinny it too
close to that of chan_sccp for your comfort, but if I were to go and re-write
that chunk of code, it'd probably look very similar.

How can we all live in harmony? Right now, I'm not sure. There is a strong
desire to get an SCCP driver into core asterisk, which provides the 
functionality people desire. Much of that functionality is in chan_sccp, and
people are using it as a reference point for what they'd like to see in
chan_skinny. Sure, some code will be written completely differently. Some will
probably look very similar. Ideas will be stolen from chan_sccp. Using an idea
does not imply stealing code. We need to be careful to keep that distinction.

To me, and I didn't analyse the posted code line by line, it looks like the
algorithm for contructing button templates has been taken from chan_sccp, but
the code is sufficiently different that it hasn't just been lifted. Is that
enough of a distinction?

Simon
-- 
Simon Lockhart | * Sun Server Colocation * ADSL * Domain Registration *
   Director    |    * Domain & Web Hosting * Internet Consultancy * 
  Bogons Ltd   | * http://www.bogons.net/  *  Email: info at bogons.net  *