[Asterisk-Dev] app_voicemail.c rework on static void vm_change_password(struct ast_vm_user *vmu, const char *newpassword)

[Michael Anderson]

On 10/5/05, Tzafrir Cohen <tzafrir.cohen at xorcom.com> wrote:
> Sorry for being so pedantic, but:
>
> On Tue, Oct 04, 2005 at 06:02:27PM -0700, Michael Anderson wrote:
> > I had a problem with password changes not being saved to the
> > voicemail.conf file and traced it to some issues with the
> > vm_change_password function in app_voicemail.c.  Comments were not
> > properly being ignored and if they contained '[' ']' characters could
> > change the currentcontext variable causing the test to fail at line
> > 690.
>
> Any way to avoid replicating code from pbx/pbx_config.c (right file?) ?

To tell the truth I just dealt with the problem we found in the one
function.  Obviously there is already a good parsing engine with the
ability to write to the config files. I assume the password change was
done as is because the voicemail.conf changes are small and we don't
want to rejoin included files just for a password change.

>
> Also:
>
> > -     while (!feof(configin)) {
> > +  while (!feof(configin)) {
>
> White space damage: it was originally indented with a tab. In your patch
> the only change is that it is indented with two spaces. Strangely
> enough, the rest of your patch is indented with tabs as most of the
> Asterisk code is.

My bad, should have seen that.

>
> Anybody with a lint command?
>
> --
> Tzafrir Cohen     icq#16849755  +972-50-7952406
> tzafrir.cohen at xorcom.com  http://www.xorcom.com
> _______________________________________________
> Asterisk-Dev mailing list
> Asterisk-Dev at lists.digium.com
> http://lists.digium.com/mailman/listinfo/asterisk-dev
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>



--
===========================
Michael Anderson