[Asterisk-Dev] ast_find_ourip and sip?

[Kevin P. Fleming]

Olle E. Johansson wrote:

> I need to check the code again and come back with a refreshed opinion.
> The ourip stuff is a bit weird and patched so many times that it is
> hard to understand. We really need better understanding in the sip 
> channel of what's going on to send from the right IP address (the right 
> interface) and use the proper IP address (which might be the externip)
> within the packets. Now I'm "shooting from the hip" without having
> reviewed the latest code...

Don't spend much time on it... the work I've been doing on one of my 
open bugs is to convert chan_sip to using ast_netsock's for all its 
communications, like chan_iax2 does.

Once that is done, handling this stuff will be easier, since we'll know 
what IP address/port packets arrived on, and we can return them using 
the same address/port. We can also look our 'external IP' for each one 
only once, and then remember what it is.