[Asterisk-Dev] H.323 lack of progress report and a patch for minor bugs

[Iain Stevenson]

Still haven't tracked down the cause of crashes on chan_h323 with my ppc 
system.  However, if I disable the call to h323_start_listener I can reload 
the H323 config in * as many times as I like.  With that call enabled * 
most likely segfaults at startup and will certainly after one or more 
reloads.

Maybe there's something wrong with what's passed to start the listener?

Anyway, I found a couple of small bugs in chan_h323.c.   In the code that 
builds the alias list there's a typo that means the secret overwrites the 
prefix.   Jitter also needs to be initialised - if the user does not 
specify jitter in the config file the jitter variable is not initialised 
when it should have the default value of 100.  Patch below.

  Iain




--- chan_h323.c.orig    Sat May 31 18:49:25 2003
+++ chan_h323.c Sat May 31 18:49:52 2003
@@ -72,7 +72,7 @@
 static int     gatekeeper_discover = 0;
 static int  usingGk;
 static int     port = 1720;
-static int     jitter;
+static int     jitter = 100;
 static int  gkroute = 0;

 /* Just about everybody seems to support ulaw, so make it a nice default */
@@ -204,7 +204,7 @@
                        } else if (!strcasecmp(v->name, "context")) {
                                strncpy(alias->context,  v->value, 
sizeof(alias->context)-1);
                        } else if (!strcasecmp(v->name, "secret")) {
-                               strncpy(alias->prefix,  v->value, 
sizeof(alias->secret)-1);
+                               strncpy(alias->secret,  v->value, 
sizeof(alias->secret)-1);
                        }
                        v = v->next;
                }