[asterisk-commits] mmichelson: branch 1.6.0 r184080 - in /branches/1.6.0: ./ apps/app_senddtmf.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Tue Mar 24 17:41:37 2009
New Revision: 184080

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=184080
Log:
Merged revisions 184079 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r184079 | mmichelson | 2009-03-24 17:40:39 -0500 (Tue, 24 Mar 2009) | 15 lines
  
  Merged revisions 184078 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r184078 | mmichelson | 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) | 9 lines
    
    Change NULL pointer check to be ast_strlen_zero.
    
    The 'digit' variable is guaranteed to be non-NULL, so the if
    statement could never evaluate true. Changing to ast_strlen_zero
    makes the logic correct.
    
    This was found while reviewing ast_channel_ao2 code review.
  ........
................

Modified:
    branches/1.6.0/   (props changed)
    branches/1.6.0/apps/app_senddtmf.c

Propchange: branches/1.6.0/
------------------------------------------------------------------------------
Binary property 'trunk-merged' - no diff available.

Modified: branches/1.6.0/apps/app_senddtmf.c
URL: http://svn.digium.com/svn-view/asterisk/branches/1.6.0/apps/app_senddtmf.c?view=diff&rev=184080&r1=184079&r2=184080
==============================================================================
--- branches/1.6.0/apps/app_senddtmf.c (original)
+++ branches/1.6.0/apps/app_senddtmf.c Tue Mar 24 17:41:37 2009
@@ -92,7 +92,7 @@
 		astman_send_error(s, m, "Channel not specified");
 		return 0;
 	}
-	if (!digit) {
+	if (ast_strlen_zero(digit)) {
 		astman_send_error(s, m, "No digit specified");
 		ast_channel_unlock(chan);
 		return 0;