[asterisk-commits] mmichelson: trunk r184079 - in /trunk: ./ apps/app_senddtmf.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Tue Mar 24 17:40:39 2009
New Revision: 184079

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=184079
Log:
Merged revisions 184078 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r184078 | mmichelson | 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) | 9 lines
  
  Change NULL pointer check to be ast_strlen_zero.
  
  The 'digit' variable is guaranteed to be non-NULL, so the if
  statement could never evaluate true. Changing to ast_strlen_zero
  makes the logic correct.
  
  This was found while reviewing ast_channel_ao2 code review.
........

Modified:
    trunk/   (props changed)
    trunk/apps/app_senddtmf.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/apps/app_senddtmf.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/apps/app_senddtmf.c?view=diff&rev=184079&r1=184078&r2=184079
==============================================================================
--- trunk/apps/app_senddtmf.c (original)
+++ trunk/apps/app_senddtmf.c Tue Mar 24 17:40:39 2009
@@ -106,7 +106,7 @@
 		astman_send_error(s, m, "Channel not specified");
 		return 0;
 	}
-	if (!digit) {
+	if (ast_strlen_zero(digit)) {
 		astman_send_error(s, m, "No digit specified");
 		ast_channel_unlock(chan);
 		return 0;