[asterisk-commits] tilghman: trunk r156756 - in /trunk: ./ apps/app_while.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Thu Nov 13 18:43:13 CST 2008


Author: tilghman
Date: Thu Nov 13 18:43:13 2008
New Revision: 156756

URL: http://svn.digium.com/view/asterisk?view=rev&rev=156756
Log:
Merged revisions 156755 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156755 | tilghman | 2008-11-13 18:41:37 -0600 (Thu, 13 Nov 2008) | 6 lines
  
  ast_waitfordigit() requires that the channel be up, for no good logical
  reason.  This prevents While/EndWhile from working within the "h"
  extension.
  Reported by: jgalarneau (for ABE C.2)
  Fixed by: me
........

Modified:
    trunk/   (props changed)
    trunk/apps/app_while.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/apps/app_while.c
URL: http://svn.digium.com/view/asterisk/trunk/apps/app_while.c?view=diff&rev=156756&r1=156755&r2=156756
==============================================================================
--- trunk/apps/app_while.c (original)
+++ trunk/apps/app_while.c Thu Nov 13 18:43:13 2008
@@ -203,11 +203,16 @@
 		return -1;
 	}
 
+#if 0
 	/* dont want run away loops if the chan isn't even up
 	   this is up for debate since it slows things down a tad ......
+
+	   Debate is over... this prevents While/EndWhile from working
+	   within the "h" extension.  Not good.
 	*/
 	if (ast_waitfordigit(chan,1) < 0)
 		return -1;
+#endif
 
 	for (x=0;;x++) {
 		if (get_index(chan, prefix, x)) {




More information about the asterisk-commits mailing list