[asterisk-commits] tilghman: branch 1.4 r156755 - /branches/1.4/apps/app_while.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Thu Nov 13 18:41:37 2008
New Revision: 156755

URL: http://svn.digium.com/view/asterisk?view=rev&rev=156755
Log:
ast_waitfordigit() requires that the channel be up, for no good logical
reason.  This prevents While/EndWhile from working within the "h"
extension.
Reported by: jgalarneau (for ABE C.2)
Fixed by: me

Modified:
    branches/1.4/apps/app_while.c

Modified: branches/1.4/apps/app_while.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_while.c?view=diff&rev=156755&r1=156754&r2=156755
==============================================================================
--- branches/1.4/apps/app_while.c (original)
+++ branches/1.4/apps/app_while.c Thu Nov 13 18:41:37 2008
@@ -181,12 +181,16 @@
 
 	u = ast_module_user_add(chan);
 
+#if 0
 	/* dont want run away loops if the chan isn't even up
 	   this is up for debate since it slows things down a tad ......
+
+	   Debate is over... this prevents While/EndWhile from working
+	   within the "h" extension.  Not good.
 	*/
 	if (ast_waitfordigit(chan,1) < 0)
 		ALL_DONE(u,-1);
-
+#endif
 
 	for (x=0;;x++) {
 		if (get_index(chan, prefix, x)) {