[asterisk-commits] murf: trunk r119930 - in /trunk: ./ res/ael/pval.c

[SVN commits to the Asterisk project]

Author: murf
Date: Tue Jun  3 10:07:20 2008
New Revision: 119930

URL: http://svn.digium.com/view/asterisk?view=rev&rev=119930
Log:
Merged revisions 119929 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r119929 | murf | 2008-06-03 08:49:46 -0600 (Tue, 03 Jun 2008) | 16 lines

as per http://lists.digium.com/pipermail/asterisk-users/2008-June/212934.html,
which is a message from Philipp Kempgen, requesting that the WARNING
that an extension is empty be reduced to a NOTICE or less, as empty
extensions are syntactically possible, and no big deal.

With which I agree, and have removed that WARNING message entirely.
I think it is not necessary to see this message. It didn't 
state that a NoOp() was inserted automatically on your behalf,
and really, as users, who cares? Why freak out dialplan writers
with unnecessary warnings? The details of the machinations a compiler goes
thru to produce working assembly code is of little interest
to most programmers-- we will follow the unix principal of
doing our work silently.



........

Modified:
    trunk/   (props changed)
    trunk/res/ael/pval.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/res/ael/pval.c
URL: http://svn.digium.com/view/asterisk/trunk/res/ael/pval.c?view=diff&rev=119930&r1=119929&r2=119930
==============================================================================
--- trunk/res/ael/pval.c (original)
+++ trunk/res/ael/pval.c Tue Jun  3 10:07:20 2008
@@ -4108,12 +4108,6 @@
 						exten-> return_target = np2;
 					}
 					/* is the last priority in the extension a label? Then add a trailing no-op */
-					if( !exten->plist_last )
-					{
-						ast_log(LOG_WARNING, "Warning: file %s, line %d-%d: Empty Extension!\n",
-								p2->filename, p2->startline, p2->endline);
-					}
-					
 					if ( exten->plist_last && exten->plist_last->type == AEL_LABEL ) {
 						struct ael_priority *np2 = new_prio();
 						np2->type = AEL_APPCALL;