[Asterisk-code-review] res_mixmonitor: MixMonitorMute by MixMonitor ID (asterisk[18])

[Michael Bradeen]

Attention is currently required from: Sean Bright, N A.

Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19969 )

Change subject: res_mixmonitor: MixMonitorMute by MixMonitor ID
......................................................................


Patch Set 4:

(1 comment)

File apps/app_mixmonitor.c:

https://gerrit.asterisk.org/c/asterisk/+/19969/comment/3d2a1013_3637018d 
PS3, Line 1559: stasis_message_blob = ast_json_pack("{s: s, s: b, s: s, s: i}",
              : 		"direction", direction,
              : 		"state", ast_true(state),
              : 		"mixmonitorid", mixmonitor_id,
              : 		"count", mutedcount);
> A couple questions about this: […]
We don't technically need either of these in the response, added for convenience but I am not opposed to removing them if it causes more problems than it's worth.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19969
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibba8c7e750577aa1595a24b23316ef445245be98
Gerrit-Change-Number: 19969
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Wed, 15 Mar 2023 15:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230315/4ebfa5ba/attachment-0001.html>