[Asterisk-code-review] res_mixmonitor: MixMonitorMute by MixMonitor ID (asterisk[18])

[Sean Bright]

Attention is currently required from: Michael Bradeen, N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19969 )

Change subject: res_mixmonitor: MixMonitorMute by MixMonitor ID
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File apps/app_mixmonitor.c:

https://gerrit.asterisk.org/c/asterisk/+/19969/comment/2c45dd36_fbcb18a6 
PS3, Line 1559: stasis_message_blob = ast_json_pack("{s: s, s: b, s: s, s: i}",
              : 		"direction", direction,
              : 		"state", ast_true(state),
              : 		"mixmonitorid", mixmonitor_id,
              : 		"count", mutedcount);
A couple questions about this:

1. I assume this will render as `... mixmonitorid: null ...` for cases where an ID is not passed?
2. What are the implications of changing this JSON structure? Is this ultimately exposed externally and, if so, should we change it in a release branches?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19969
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibba8c7e750577aa1595a24b23316ef445245be98
Gerrit-Change-Number: 19969
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Wed, 15 Mar 2023 14:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230315/c00ab0a8/attachment.html>