[Asterisk-code-review] install_prereq: Refactoring and enhancements. (asterisk[master])

[Sean Bright]

Attention is currently required from: Mark Murawski, Martin McCarthy.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19939 )

Change subject: install_prereq: Refactoring and enhancements.
......................................................................


Patch Set 3: Code-Review-2

(1 comment)

Patchset:

PS3: 
There are many syntax and logical errors in here. Even just running it without passing any arguments results in:

 ./contrib/scripts/install_prereq: 645: [: Illegal number: 
 
I think that you can address the 3 issues you raised in your bug report:

 * There was no debug in the terminal to tell me it was doing anything.
 * The help wasn't not very verbose.
 * Linux Mint was not supported.
 
... without rewriting the entire script. I would suggest you limit the scope of your changes to the 3 items above.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4bd53ae429e113a76d13a23b48da714a8eefad26
Gerrit-Change-Number: 19939
Gerrit-PatchSet: 3
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 15:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230308/b1466275/attachment.html>