[Asterisk-code-review] install_prereq: Refactoring and enhancements. (asterisk[master])

[Sean Bright]

Attention is currently required from: Mark Murawski, Martin McCarthy.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19939 )

Change subject: install_prereq: Refactoring and enhancements.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19939/comment/a8f5af8a_ffc6f2df 
PS3, Line 9: Files changed;
           : 
           : contrib/scripts/install_prereq.sh
You do not need to list the files changed.


File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/asterisk/+/19939/comment/934ac8e9_1c091b1c 
PS3, Line 645: -eq
`-eq` is for arithmetic comparisons. `[ -z "$1" ]` would be better.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4bd53ae429e113a76d13a23b48da714a8eefad26
Gerrit-Change-Number: 19939
Gerrit-PatchSet: 3
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230308/9ea6d4b6/attachment.html>