[Asterisk-code-review] res_pjsip: Replace invalid UTF-8 sequences in callerid name (asterisk[18])

[Sean Bright]

Attention is currently required from: Joshua Colp, George Joseph.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19898 )

Change subject: res_pjsip: Replace invalid UTF-8 sequences in callerid name
......................................................................


Patch Set 12: Code-Review-1

(4 comments)

File include/asterisk/utf8.h:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/db41da41_fad3a143 
PS11, Line 121: str
`str` -> `src`


File main/stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/4ac4c978_11054303 
PS11, Line 1172: AST_UTF8_VALID
`AST_UTF8_REPLACE_VALID`


File main/utf8.c:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/c2de91e6_81c7010a 
PS11, Line 32: #include "asterisk/json.h"
Could this be moved into the `#ifdef TEST_FRAMEWORK` block below? It's only needed when test framework is built.


File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/72bc6809_c3bd5a32 
PS11, Line 2496: AST_UTF8_VALID
`AST_UTF8_REPLACE_VALID`



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19898
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I4ffbdb19c80bf0efc675d40078a3ca4f85c567d8
Gerrit-Change-Number: 19898
Gerrit-PatchSet: 12
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 15:23:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230301/0fab0b7f/attachment.html>