[Asterisk-code-review] res_pjsip: Replace invalid UTF-8 sequences in callerid name (asterisk[18])
George Joseph
asteriskteam at digium.com
Wed Mar 1 09:21:25 CST 2023
Attention is currently required from: Sean Bright, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19898 )
Change subject: res_pjsip: Replace invalid UTF-8 sequences in callerid name
......................................................................
Patch Set 11:
(2 comments)
File main/utf8.c:
https://gerrit.asterisk.org/c/asterisk/+/19898/comment/29ecdfae_f3e3323a
PS10, Line 32: #include "asterisk/json.h"
> Could this be moved to inside the `#ifdef TEST_FRAMEWORK` block?
Done
https://gerrit.asterisk.org/c/asterisk/+/19898/comment/1ca64c97_b8c67edf
PS10, Line 147: if (!dst || !src) {
> This change seems unrelated to the main purpose of this review. […]
Done
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19898
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I4ffbdb19c80bf0efc675d40078a3ca4f85c567d8
Gerrit-Change-Number: 19898
Gerrit-PatchSet: 11
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 15:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230301/8458bdc4/attachment.html>
More information about the asterisk-code-review
mailing list