[Asterisk-code-review] app_read: add option to return terminator on empty digits (asterisk[18])

[N A]

Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19883 )

Change subject: app_read: add option to return terminator on empty digits
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/19883/comment/17cb8881_71908559 
PS1, Line 91: 					</option>
The JIRA issue says "This can allow for more distinction between timeouts and specifically chosen empty-strings."

Can't you already distinguish this by checking READSTATUS for "TIMEOUT" vs "OK"?

Seems fine either way, but since this seems similar to or at least related to the t option, maybe an example for the two using <example> would be nice here to help users out.


https://gerrit.asterisk.org/c/asterisk/+/19883/comment/0d253981_42c1d8fd 
PS1, Line 272: 				}
else should be on the same line


https://gerrit.asterisk.org/c/asterisk/+/19883/comment/1d375634_edf94d1a 
PS1, Line 283: 				}
Same here, I know you added braces but the else should be on the same line as the closing brace of previous else if



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I49f3221824330a193a20c660f99da0f1fc2cbbc5
Gerrit-Change-Number: 19883
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 11:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230131/f1c08d19/attachment.html>