<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19883">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_read.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19883/comment/17cb8881_71908559">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace">                                  </option></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The JIRA issue says "This can allow for more distinction between timeouts and specifically chosen empty-strings."</p><p style="white-space: pre-wrap; word-wrap: break-word;">Can't you already distinguish this by checking READSTATUS for "TIMEOUT" vs "OK"?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Seems fine either way, but since this seems similar to or at least related to the t option, maybe an example for the two using <example> would be nice here to help users out.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19883/comment/0d253981_42c1d8fd">Patch Set #1, Line 272:</a> <code style="font-family:monospace,monospace">                         }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">else should be on the same line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19883/comment/1d375634_edf94d1a">Patch Set #1, Line 283:</a> <code style="font-family:monospace,monospace">                             }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, I know you added braces but the else should be on the same line as the closing brace of previous else if</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19883">change 19883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19883"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I49f3221824330a193a20c660f99da0f1fc2cbbc5 </div>
<div style="display:none"> Gerrit-Change-Number: 19883 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:22:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>