[Asterisk-code-review] chan_iax2: Fix jitterbuffer regression prior to receiving audio. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: N A, Joshua Colp.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19712 )

Change subject: chan_iax2: Fix jitterbuffer regression prior to receiving audio.
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
Hi,

This looks good to me.  My patch is simpler but this is potentially more correct.

As best I can understand, this issue only occurs when we're dealing with early media.

I don't like the comment for the reason this is receiving a voice frame, which invalidates the comment, I'm not sure when voiceformat gets set but I believe it's when the call gets answered, which then sets the voice frame types we are permitted to send?

I've yet to see a case where the codecs isn't symmetric but theoretically it is entirely possible from what I understand.

In the case where the fallback mechanism also fails to obtain a time-value, we should either log that case, so that we can solve it, or default to the used-to-be default of 20ms.  Your call.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19712
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fd1e8e088a145ad89e0427c2100a530e964fe9
Gerrit-Change-Number: 19712
Gerrit-PatchSet: 4
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Jaco Kroon <jaco at uls.co.za>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 11:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230130/8683c05e/attachment.html>