[Asterisk-code-review] chan_iax2: Fix jitterbuffer regression prior to receiving audio. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: N A, Joshua Colp.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19712 )

Change subject: chan_iax2: Fix jitterbuffer regression prior to receiving audio.
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
I'm not 100% certain of the statement.

When do we actually set voiceformat?  The current issue is seen (as far as I could determine) when we're receiving early media, which is a voice frame.  But at this stage we're not (afaik) always told yet what we're allowed to SEND.

Either way, I'm happy with this patch except I think mine is simpler, but possibly less correct.

Yours could drop frames without it getting logged (goto cleanup).  Please make sure this doesn't result in leaked frames, and I'd want to add logging about that specific case, or that it then falls back to just using 20ms as the original code did (and my patch does).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19712
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fd1e8e088a145ad89e0427c2100a530e964fe9
Gerrit-Change-Number: 19712
Gerrit-PatchSet: 4
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Jaco Kroon <jaco at uls.co.za>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 11:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230130/defd8d50/attachment.html>