[Asterisk-code-review] media cache: make sure generated filenames cannot conflict (asterisk[master])

[Sean Bright]

Attention is currently required from: Nathan Bruning.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19797 )

Change subject: media cache: make sure generated filenames cannot conflict
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
Some thoughts:

A better approach would be to modify bucket_file_update_path(…) in main/media_cache.c to handle this or, alternatively, to change to using mkdtemp() instead of mkstemp() to create the temporary file paths in the first place.

The latter will result in changing how the cache is structured but should avoid any naming conflicts.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19797
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4
Gerrit-Change-Number: 19797
Gerrit-PatchSet: 1
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Fri, 27 Jan 2023 16:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230127/9f75ab41/attachment-0001.html>