[Asterisk-code-review] media cache: make sure generated filenames cannot conflict (asterisk[master])

[N A]

Attention is currently required from: Nathan Bruning.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19797 )

Change subject: media cache: make sure generated filenames cannot conflict
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

File include/asterisk/bucket.h:

https://gerrit.asterisk.org/c/asterisk/+/19797/comment/71c99db8_89d64d71 
PS1, Line 458:  * 
trailing whitespaces


File main/bucket.c:

https://gerrit.asterisk.org/c/asterisk/+/19797/comment/1fb0682a_691b8c22 
PS1, Line 926: 	for(i=0; i<100; i++) {
Spaces are needed in the for, please see the Asterisk Coding Guidelines


https://gerrit.asterisk.org/c/asterisk/+/19797/comment/d8cfe0dc_b72beb3f 
PS1, Line 926: 	for(i=0; i<100; i++) {
This seems clunky. What is the justification for 100? In what cases would an infinite loop occur? Is there a better way of detecting this without looping?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19797
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4
Gerrit-Change-Number: 19797
Gerrit-PatchSet: 1
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Fri, 27 Jan 2023 15:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230127/1df3d2fe/attachment.html>