[Asterisk-code-review] app_directory: add ability to specify configuration file (asterisk[18])

N A asteriskteam at digium.com
Thu Jan 26 12:55:07 CST 2023


Attention is currently required from: Michael Bradeen, Richard Mudgett.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19794 )

Change subject: app_directory: add ability to specify configuration file
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File apps/app_directory.c:

https://gerrit.asterisk.org/c/asterisk/+/19794/comment/1ae223ae_90626b18 
PS2, Line 108: 						<argument name="s" required="true" />
This isn't very descriptive, how about "filename" instead of "s"?
voicemail.conf could also go in <filename> here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19794
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Id58ccb1344ad1e563fa10db12f172fbd104a9d13
Gerrit-Change-Number: 19794
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 26 Jan 2023 18:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230126/a28b8f13/attachment.html>


More information about the asterisk-code-review mailing list