[Asterisk-code-review] app_directory: add ability to specify configuration file (asterisk[18])

[Michael Bradeen]

Attention is currently required from: N A, Richard Mudgett.

Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19794 )

Change subject: app_directory: add ability to specify configuration file
......................................................................


Patch Set 2:

(3 comments)

File apps/app_directory.c:

https://gerrit.asterisk.org/c/asterisk/+/19794/comment/38f647fc_b8c47a14 
PS1, Line 113: 			<parameter name="filename" required="false">
> Rather than adding another optional positional argument where you can miscount the commas, this shou […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19794/comment/4da42037_0299449d 
PS1, Line 484: 	else {
> The else opening brace should be on the same line. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19794/comment/b8c688ca_7b05f3c1 
PS1, Line 880: 		ast_log(LOG_NOTICE, "Load custom directory file: %s\n", args.filename);
> This should NOT be a NOTICE log. It should be a debug message if it's even necessary.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19794
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Id58ccb1344ad1e563fa10db12f172fbd104a9d13
Gerrit-Change-Number: 19794
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 26 Jan 2023 18:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230126/8a7dbf9d/attachment-0001.html>