[Asterisk-code-review] app_signal: Add signaling applications (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Mark Murawski.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17786 )

Change subject: app_signal: Add signaling applications
......................................................................


Patch Set 7:

(1 comment)

File apps/app_signal.c:

https://gerrit.asterisk.org/c/asterisk/+/17786/comment/96a3b4f1_88a256f4 
PS6, Line 373: 		ast_verb(3, "Channel '%s' timed out, waiting for signal '%s'\n", ast_channel_name(chan), args.signame);
> Yeah the user could send a user event, but everything else under the sun has AMI events. […]
I disagree that "everything else under the sun" has AMI events. It's not a completely far reaching pattern, and for something as niche as this I don't think AMI events are warranted. As stated if someone using this really wants it, then the possibility exists without putting it upon everyone else.

As for "doing things automatically" there's a time and a place. Things have a cost, including AMI events (even if you filter them out on the AMI side) and that must be taken into account. A blanket "AMI event all the places and all the things" is harmful. See: VarSet. I don't know whether that would have been an event these days.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17786
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3
Gerrit-Change-Number: 17786
Gerrit-PatchSet: 7
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Thu, 26 Jan 2023 15:13:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230126/c30a034b/attachment-0001.html>