[Asterisk-code-review] app_signal: Add signaling applications (asterisk[master])

[Mark Murawski]

Attention is currently required from: N A, Joshua Colp.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17786 )

Change subject: app_signal: Add signaling applications
......................................................................


Patch Set 7:

(2 comments)

File apps/app_signal.c:

https://gerrit.asterisk.org/c/asterisk/+/17786/comment/8d181217_cd0e2573 
PS6, Line 373: 		ast_verb(3, "Channel '%s' timed out, waiting for signal '%s'\n", ast_channel_name(chan), args.signame);
> I'm not sure what there could be on the "waiting for" part... […]
Yeah the user could send a user event, but everything else under the sun has AMI events.  Some people use AMI for logging, so someone in theory could write perf counts on things like how many signals went out, how many were timed out.  Just seems useful to do that automatically.  (I'm a fan of doing things automatically when it makes sense to do so).

If you don't want to add AMI, I can see the rationale there as well.  It's under the 'nice to have' category.


https://gerrit.asterisk.org/c/asterisk/+/17786/comment/527441c1_113e9e70 
PS6, Line 453: oad
> Isn't this kind of redundant? […]
Same as above... if you want to not implement, that's fine, also a 'nice to have' sort of thing for specifics.  One surely can do a DumpChannels and see which thing is executing what, but then it's more work for the user to do so... when the module itself has direct access to this list.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17786
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3
Gerrit-Change-Number: 17786
Gerrit-PatchSet: 7
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 26 Jan 2023 15:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230126/be305259/attachment.html>