[Asterisk-code-review] app_directory: add ability to specify configuration file (asterisk[18])

[N A]

Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19794 )

Change subject: app_directory: add ability to specify configuration file
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File apps/app_directory.c:

https://gerrit.asterisk.org/c/asterisk/+/19794/comment/0453d097_5554b51f 
PS1, Line 484: 	else {
The else opening brace should be on the same line.
Really though, I think you should just use the ternary operator - or better yet, S_OR:

cfg = ast_config_load(S_OR(filename, VOICEMAIL_CONFIG), config_flags);


https://gerrit.asterisk.org/c/asterisk/+/19794/comment/015d6d81_c1955b03 
PS1, Line 880: 		ast_log(LOG_NOTICE, "Load custom directory file: %s\n", args.filename);
This should NOT be a NOTICE log. It should be a debug message if it's even necessary.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19794
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Id58ccb1344ad1e563fa10db12f172fbd104a9d13
Gerrit-Change-Number: 19794
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Thu, 26 Jan 2023 13:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230126/b6ef2d0e/attachment-0001.html>