[Asterisk-code-review] app_directory: add ability to specify configuration file (asterisk[18])

[Richard Mudgett]

Attention is currently required from: Michael Bradeen.

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19794 )

Change subject: app_directory: add ability to specify configuration file
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File apps/app_directory.c:

https://gerrit.asterisk.org/c/asterisk/+/19794/comment/36e381bd_828808d7 
PS1, Line 113: 			<parameter name="filename" required="false">
Rather than adding another optional positional argument where you can miscount the commas, this should be added as another lettered option.
A 'c' option for config is available.
Directory(,,c(alternate_voicemail.conf))

This way we will not get stuck with dead positions in the future like we just got with app_dial and app_queue when macro was removed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19794
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Id58ccb1344ad1e563fa10db12f172fbd104a9d13
Gerrit-Change-Number: 19794
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Wed, 25 Jan 2023 23:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230125/5bfd8a2f/attachment.html>