[Asterisk-code-review] res_stasis_snoop: Fix snoop crash (asterisk[master])

[sungtae kim]

Attention is currently required from: Joshua Colp.

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19781 )

Change subject: res_stasis_snoop: Fix snoop crash
......................................................................


Patch Set 4:

(1 comment)

File res/res_stasis_snoop.c:

https://gerrit.asterisk.org/c/asterisk/+/19781/comment/4939f321_c8326195 
PS4, Line 139: 		ast_channel_lock(snoop->spyee_chan);
> Is the locking here still required?
Yes, this is a required one. The spyee_chan need to be locked until it gets the snapshot.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibdc675f98052da32333b19685b1708a3751b6d24
Gerrit-Change-Number: 19781
Gerrit-PatchSet: 4
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 17 Jan 2023 01:01:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230117/e4f2d3e9/attachment-0001.html>