[Asterisk-code-review] res_stasis_snoop: Fix snoop crash (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Jan 12 11:01:14 CST 2023


Attention is currently required from: sungtae kim.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19781 )

Change subject: res_stasis_snoop: Fix snoop crash
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File res/res_stasis_snoop.c:

https://gerrit.asterisk.org/c/asterisk/+/19781/comment/c8fb751f_06cc58c6 
PS4, Line 139: 		ast_channel_lock(snoop->spyee_chan);
Is the locking here still required?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibdc675f98052da32333b19685b1708a3751b6d24
Gerrit-Change-Number: 19781
Gerrit-PatchSet: 4
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 17:01:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230112/aa19b355/attachment-0001.html>


More information about the asterisk-code-review mailing list