[Asterisk-code-review] res_pjsip: Replace invalid UTF-8 sequences in callerid name (asterisk[18])

[Sean Bright]

Attention is currently required from: George Joseph.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19898 )

Change subject: res_pjsip: Replace invalid UTF-8 sequences in callerid name
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

Patchset:

PS6: 
I want to do some testing of how the replacement characters are handled, but at a minimum the refactoring of the JSON UTF-8 routines to use the ones in utf8.h should happen in a different review.

Additionally, I don't understand why unrelated UTF-8 functions were modified (switching an 'assert' to an 'if' for example)?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19898
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I4ffbdb19c80bf0efc675d40078a3ca4f85c567d8
Gerrit-Change-Number: 19898
Gerrit-PatchSet: 6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 20:08:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230227/fddb695e/attachment.html>